Handle non-hashable types in printing/formatting #12324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ipython#12320 For more information, see: ipython#12320
jluttine
commented
May 21, 2020
Comment on lines
-425
to
+429
| if cls in self.type_printers or self._in_deferred_types(cls): | ||
| try: | ||
| return self.type_printers[cls] | ||
|
|
||
| except (KeyError, TypeError): | ||
| pass | ||
|
|
There was a problem hiding this comment.
I'm not entirely sure about this change. In the original code, the if-clause was True even if cls is not in self.type_printers, but self._in_deferred_types(cls) evaluates to True. Doesn't self.type_printers[cls] raise KeyError in that case? So, that was a bit unclear to me, maybe there's some hidden magic happening and this change isn't correct. I wasn't able to run the tests for this module because I just got a huge bunch of failures on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12320
For more information, see: #12320