Fixed bug on windows where relative image path has wrong slashes #12342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! Your commit does not seem to be associated with your GitHub email, I just want to make sure you are aware in case you want to fix it before I merge. |
|
No Problem! Thanks for the catch, I changed the email on the commit. |
|
Thanks ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
May 29, 2020
…path has wrong slashes
Carreau
added a commit
that referenced
this pull request
May 29, 2020
…342-on-7.x Backport PR #12342 on branch 7.x (Fixed bug on windows where relative image path has wrong slashes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the
source_diris not posix and thus the call toos.path.relpathreturns something like'_build\html\_static'. This causes the image to not load as sphinx expects a posix path. Using
pathlib.Pathfor all of the manipulation and callingas_posix()at the end ensures the value ofoutfileis always a posix string.