Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed key map name to match changes to python mode #1242

Closed
wants to merge 1 commit into from
Closed

changed key map name to match changes to python mode #1242

wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Contributor

This is a minor change to handling the python-mode key mappings. In reversion 752
( http://bazaar.launchpad.net/~python-mode-devs/python-mode/python-mode/revision/752 ) the name of the map was changed from py-mode-map to python-mode-map.

This isn't in any distributions yet, so I am not sure how you want to deal with this.

@fperez
Copy link
Member

fperez commented Jan 20, 2012

Well, b/c the change will depend on the version of python-mode the users have, this change alone can't be used, as it will break for anyone who is still using the older versions. So unless you can provide a version that uses the right elisp api calls to verify which of the two names to use first, I'm afraid we can't include it in this form.

@tacaswell
Copy link
Contributor Author

python-mode developers are still trying to sort out what they want to do about this as well ( https://bugs.launchpad.net/python-mode/+bug/912919 ). When they sort out how to handle the renaming I will update this.

Should I close the pull request for now?

@fperez
Copy link
Member

fperez commented Jan 21, 2012

Yes, I thnk closing until a cleaner direction is available from upstream is best; we can then find the right approach for us. I'll close it now.

@fperez fperez closed this Jan 21, 2012
@fperez
Copy link
Member

fperez commented Jan 21, 2012

BTW, thanks for pitching in! In general, emacs support is one of our weakest spots, so your participation on this front will really help the project.

@tacaswell
Copy link
Contributor Author

The resolution on the python-mode end is that they provide the functionality of ipython.el internally.

@andreas-roehler
Copy link

python-mode now provides a

(defvar py-mode-map python-mode-map)

this should do it.

Please alert me if not.

Cheers,

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants