Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made notebook.html extend layout.html #1299

Merged
merged 0 commits into from
Jan 28, 2012
Merged

Conversation

hhuuggoo
Copy link

Conflicts:

IPython/frontend/html/notebook/templates/notebook.html

@fperez
Copy link
Member

fperez commented Jan 20, 2012

For reference, this is a restart with a clean branch of #1278, where more discussion can be found.

@fperez
Copy link
Member

fperez commented Jan 24, 2012

Ooops, @hhuuggoo: sorry to say this, but it seems that in the meantime this one developed a conflict and doesn't merge cleanly. Could you please rebase it on top of master and push again (you'll need to use git push --force)? You'll have to fix some conflicts, but I think they should be pretty minimal.

Please let us know if you need a hand...

We'll do our best to review it quickly after the rebase so that this doesn't happen again.

@ellisonbg
Copy link
Member

@hhuuggoo, can you rebase this so we can finish the review?

@hhuuggoo
Copy link
Author

yes sorry, I'll take care of it this weekend.

On 01/27/2012 12:52 PM, Brian E. Granger wrote:

@hhuuggoo, can you rebase this so we can finish the review?


Reply to this email directly or view it on GitHub:
#1299 (comment)

@hhuuggoo hhuuggoo merged commit 426a986 into ipython:master Jan 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants