Don't access current_frame f_locals #13021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix ipython#13020 Though it's a suttle enough bug that tests needs to be written. And we can't rely on doctests as they are not ran.
|
I'm still not sure if I understand why accessing I wonder why I never noticed this. |
|
This is probably related, but Pdb in cpython use self.curframe_locals as well, so it's likely on purpose. |
|
Test added. |
MrMino
reviewed
Jun 22, 2021
Co-authored-by: Blazej Michalik <6691643+MrMino@users.noreply.github.com>
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jun 23, 2021
|
For anyone interested, and for the future me - it's the call to This has few other funny quirks that might bite us in the future, if pdb fixes any and we manage to shadow the patch in ipdb. There's a draft PEP for fixing the |
Carreau
added a commit
that referenced
this pull request
Jun 24, 2021
…021-on-7.x Backport PR #13021 on branch 7.x (Don't access current_frame f_locals)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #13020
Though it's a suttle enough bug that tests needs to be written.
And we can't rely on doctests as they are not ran.