allow for spaces in magic arguments, fixes #12729 #13027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivanov
commented
Jun 24, 2021
•
ivanov
commented
- a failing test
- new code
- change to tests that break with the new code, due to backwards incompatibility
- documentation of backwards incompatible change
ivanov
added a commit
to noteable-io/noteable-notebook-magics
that referenced
this pull request
Jun 24, 2021
This is a workaround until the fix lands in IPython 8.0 via ipython/ipython#13027
|
Windows 💥 |
every dang time, man |
MrMino
reviewed
Jun 25, 2021
I didn't realize Does it actually work? I have no way of checking how the call stack looks like, I don't have any win32 on hand 😛. Edit: oh, right, so the appveyor thing is actually about the win32 test, not intermittent. Nvm then. |
Co-authored-by: Blazej Michalik <6691643+MrMino@users.noreply.github.com>
ivanov
added a commit
to noteable-io/noteable-notebook-magics
that referenced
this pull request
Jun 29, 2021
This is a workaround until the fix lands in IPython 8.0 via ipython/ipython#13027
ivanov
added a commit
to noteable-io/noteable-notebook-magics
that referenced
this pull request
Jun 30, 2021
This is a workaround until the fix lands in IPython 8.0 via ipython/ipython#13027
ivanov
added a commit
to noteable-io/noteable-notebook-magics
that referenced
this pull request
Jun 30, 2021
This is a workaround until the fix lands in IPython 8.0 via ipython/ipython#13027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.