Pathlib in IPython/paths.py #13210
Open
Pathlib in IPython/paths.py #13210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deep-jkl
force-pushed
the
pathilb-in-core-paths
branch
from
121e1fe
to
c0d1002
Compare
|
Apologies for delay in reviewing, the last few weeks/next few ones have been busy. I'll do my best to review when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed usage of os.path in IPython/paths.py.
I have updated tests accordingly (primarily to not use os.path).
However, there is a change, former code utilized os.path.realpath, which is not equivalent to pathlib.Path.resolve(). The former converts path to absolute. I have addressed this matter in tests, but I am not sure that it won't affect the library in general.