Mock urlopen when starting doctests #13596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Carreau is this acceptable? |
MrMino
force-pushed
the
image-tests-mock-network
branch
from
c71261e
to
1fbd184
Compare
|
I think that would be acceptable. I'm not fluent in mock, but I assume it's possible to make it return different values depending on the URL that is given to it to actually fake the requests ? |
|
Yes, it's possible to patch it with a custom factory (see Note to self:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for #13468 (speculative - because I haven't checked whether it does what it does ;)).
Closes #13468.