Add completion types for completions obtained with matchers #13734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12820 by adding a property-setting decorator to matcher functions which allows to pass additional metadata about matches returned by the matcher functions. I kept the changes to minimum to maintain full backward-compatibility, and I refrained from refactoring to
NamedTuple
s being wary of potential performance penalty.Regarding implementation as in this PR
General questions:
matcher
decorators be exposed as public API? The matchers are already exposed publicly viaIPCompleter.custom_matchers
, so it might be useful to someone, but sincecustom_matchers
is not documented anywhere I don't think this is a must%config
and%colors
completions, or should both be mapped toparam
?For context:
module
,class
,instance
,function
,param
,path
,keyword
,property
andstatement
Text
,Method
,Function
,Constructor
,Field
,Variable
,Class
,Interface
,Module
,Property
,Unit
,Value
,Enum
,Keyword
,Snippet
,Color
,File
,Reference
,Folder
,EnumMember
,Constant
,Struct
,Event
,Operator
,TypeParameter
Notes:
Protocol
, but is only available since Python 3.8 (or waiting until Declare and use attributes of function objects python/mypy#2087 gets addressed).