Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IPCompleter Matcher API #13745

Merged
merged 14 commits into from Oct 5, 2022
Merged

Refactor IPCompleter Matcher API #13745

merged 14 commits into from Oct 5, 2022

Commits on Sep 5, 2022

  1. Refactor IPCompleter Matcher API

    @krassowski
    krassowski committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d22310b View commit details
    Browse the repository at this point in the history

  2. Shim TypedDict and NotRequired at runtime until 

    the lowest supported Python version catches up.
    @krassowski
    krassowski committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    728bad9 View commit details
    Browse the repository at this point in the history

  3. Update ipdoctest test

    @krassowski
    krassowski committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    93c8b4d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Implement priority, do_not_suppress, add tests and docs.

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cce8529 View commit details
    Browse the repository at this point in the history

  2. Correct suppression defaults, add a test for ipython#13735

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    21f1467 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into completion-matcher

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b0daec1 View commit details
    Browse the repository at this point in the history

  4. Improve type hinting and documentation

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d137c7a View commit details
    Browse the repository at this point in the history

  5. Move typing_extensions optional dependency

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b61b12e View commit details
    Browse the repository at this point in the history

  6. highlight → code-block

    @krassowski
    krassowski committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    56b6489 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Fix backslash combining matchers (they require text_until_cursor).

    @krassowski
    krassowski committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    37590bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into completion-matcher

    @krassowski
    krassowski committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    88889c1 View commit details
    Browse the repository at this point in the history

  3. Relax constraint on limit to allow no limit

    @krassowski
    krassowski committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    62af0b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Remove outdated header as suggested 

    Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
    @krassowski @Carreau
    krassowski and Carreau committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    5bb0259 View commit details
    Browse the repository at this point in the history

  2. Switch CompletionContext to dataclass, use cached_property 

    Data class has narrower API than named tuple (does not expose item getters)
which means it is less likely that the downstream code would be broken in
the future if we introduce new attributes. Also, compared to other places
where memory-efficient named tuple is used, `CompletionContext` is only
created once per completion and thus does not require as low overhead.
For the same reason we can forgo slightly more memory-efficient
`@property @cache` stack and just use `@cached_property`.
    @krassowski
    krassowski committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ab60d31 View commit details
    Browse the repository at this point in the history