fix %tb after SyntaxError #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizes expectations between `showtraceback()` and `showsyntaxerror()`, and ensures that `sys.last_type`, etc. have the right value.
|
Thx, this fixed the bug for me! |
minrk
added a commit
that referenced
this pull request
Mar 8, 2012
fix %tb after SyntaxError Moves exc_info extraction to Shell._get_exc_info, since it was done twice in different places, and differently. Synchronizes expectations between showtraceback() and showsyntaxerror(), and ensures that sys.last_type, etc. get the right value. Previously failing test added.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix %tb after SyntaxError Moves exc_info extraction to Shell._get_exc_info, since it was done twice in different places, and differently. Synchronizes expectations between showtraceback() and showsyntaxerror(), and ensures that sys.last_type, etc. get the right value. Previously failing test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
exc_infoextraction toShell._get_exc_info, since it was done twice in different places, and differently.Synchronizes expectations between
showtraceback()andshowsyntaxerror(), and ensures thatsys.last_type, etc. get the right value.Previously failing test added.
Bug reported by @Thisch