Don't do truthy check on object; use is not None
#14004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, without this change, doing `df.merge?` on a pandas DataFrame currently fails, because `df.__bool__()` raises an exception.
|
oops, thanks. I will try to take care of this a and add a test. |
Carreau
force-pushed
the
no_implied_bool_on_parent
branch
from
ef2d6b6
to
58d949d
Compare
Carreau
force-pushed
the
no_implied_bool_on_parent
branch
from
58d949d
to
6224ea7
Compare
|
meeseeksdev backport to 8.12.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Apr 25, 2023
Carreau
added a commit
to meeseeksmachine/ipython
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, without this change, doing
df.merge?on a pandas DataFrame currently fails, becausedf.__bool__()raises an exception.I'm not sure the best way to add a test, and at a glance I didn't see any issue for this yet.
This regression was introduced in #13975 and version 8.12.0. CC @Carreau