Allow safe access to the __getattribute__ method of modules

[ccordoba12]

This restores code completions of second-level modules when Jedi completions are disabled.

Fixes #14028

[ccordoba12]

@krassowski, I don't understand very well how to add a test for this, so I'd appreciate your guidance for that.

[krassowski]

Maybe something like:

def test_module_access():
    import sys
    context = limited(sys=sys)
    assert guarded_eval("sys.copyright", context) == sys.copyright

    context = minimal(sys=sys)
    with pytest.raises(GuardRejection):
        guarded_eval("sys.copyright", context)

in IPython/core/tests/test_guarded_eval.py?

[ccordoba12]

Thanks @krassowski! I implemented the same test but using Numpy because I think it's a more important use case.

[krassowski]

LGTM, thank you @ccordoba12!

[Carreau]

Hum,

I missed that in the previous PR but those should likely be :

from types import MethodDescriptorType
from types import ModuleType

Not blocking so let's open as another issue.

[krassowski]

Oh, MethodDescriptorType is neat. I missed it being added in 3.7, but since we are not supporting 3.6 for some time now this is good idea indeed.

[Carreau]

Technically we don't even support 3.8 anymore, so plenty of new things you can use !

[ccordoba12]

I can take care of this.

[ccordoba12]

@Carreau, could this fix be backported to the 8.12 branch? We still have a lot of people that uses Python 3.8 in Spyder, so we'd like them to benefit from it.

[Carreau]

meeseeksdev backport to 8.12.x