MAINT: reintroduce a OInfo get method for backward compatibility. #14033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we not deprecate it, or at least not deprecate it for existing fields? |
|
Sure, we could, but then it remove the advantage of having static checking of existing fields. Can we compromise to "pending deprecation", and in like 2 years we deprecate ? |
|
How about a 6mo reprieve? The goal would be to get a version of h5py that (conditionally) use the fields before it warns (because warnings showing up in completion is also super annoying ....) |
|
Sure. |
Carreau
commented
Apr 26, 2023
|
xref h5py/h5py#2256 |
Reintroduce a OInfo get method for backward compatibility. OInfo was converted to a dataclass from dict in commit 0fef298, but some external code is still be using it. This commit reintroduces the method, but we don't deprecated it yet ! Fixes h5py/h5py#2253
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Apr 28, 2023
…backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce a OInfo get method for backward compatibility.
OInfo was converted to a dataclass from dict in commit 0fef298, but some external code is still be using it.
This commit reintroduces the method, but deprecates it.
Fixes h5py/h5py#2253