Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional pickleshare #14217

Merged
merged 2 commits into from Oct 27, 2023
Merged

optional pickleshare #14217

merged 2 commits into from Oct 27, 2023
+23 −2

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Oct 24, 2023

No description provided.

@Carreau Carreau added this to the 8.17 milestone Oct 27, 2023
@Carreau Carreau merged commit 1a05e90 into ipython:main Oct 27, 2023
21 checks passed
@RafalSkolasinski
Copy link

I believe due to this change there is an annoying warning appearing when trying to complete root modules

Python 3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.17.2 -- An enhanced Interactive Python. Type '?' for help.

/home/rskolasinski/miniconda3/envs/test/lib/python3.10/site-packages/IPython/core/completerlib.py:120: UserWarning: using rootmodules_cache requires you to install the `pickleshare` library.
  rootmodules_cache = ip.db.get('rootmodules_cache', {})
In [1]: import os

@dionhaefner dionhaefner mentioned this pull request Nov 6, 2023
Open
@Carreau Carreau deleted the optional-pickleshare branch January 14, 2024 17:35
@jakirkham jakirkham mentioned this pull request Feb 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Carreau @RafalSkolasinski