New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use XDG path on OS X #1794
Conversation
This should never have been used on OS X. A few relevant tests added and adjusted appropriately.
Unlikely to hit problem, but better to do it cleanly. Looks good, merging. |
Don't use XDG path on OS X. While unlikely to be an issue in practice, an occasional bad OS X citizens could create a ~/.config dir, and new OS X installs of IPython after this point would use this dir.
Just for reference, on OS X, my |
Mmh, it was bound to have hit someone :) There must be a rule somewhere about how, no matter how unlikely a corner case of your code may be, someone on the internet will be hit by it. With the corollary that if it's not a flat-out crashing bug, someone will also depend on it :) |
I kind of liked having it under |
We have a solution for you: |
Don't use XDG path on OS X. While unlikely to be an issue in practice, an occasional bad OS X citizens could create a ~/.config dir, and new OS X installs of IPython after this point would use this dir.
I will use the workaround - however - XDG is not a macOS spec spec, but if a macOS user went through the trouble of setting the environment variable, then they probably want it to be used. Git, for example, uses XDG_CONFIG_HOME on macOS if it is set. And I think we're all happier for it. |
@jcrben good point. Respecting the environment variable when set and using XDG defaults aren't the same thing. We could still respect the env when set while having platform-appropriate defaults when not set. |
This should never have been used on OS X.
A few relevant tests adjusted and added appropriately.
It would rarely come up, but occasional bad OS X citizens would create a ~/.config dir, and new OS X installs of IPython after this point would use this dir.
It's entirely possible that zero users have been affected by this so far.