Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External cleanup #1839

Merged
merged 2 commits into from Jun 6, 2012
Merged

External cleanup #1839

merged 2 commits into from Jun 6, 2012

Conversation

juliantaylor
Copy link
Contributor

remove pyparsing external which is unused
remove mglob external which is only used by quarantined code

Closes gh-1838

added comment about removal to ipy_fsops.py
removed use from ipy_profile_sh.py
removed documentation on previously removed %mglob magic
@takluyver
Copy link
Member

We've previously provided pyparsing for third parties to use in their own prefilter transformers, so we shouldn't just remove it with no warning. As a minimum, we should post to the ipython-user list to ask if anyone knows of code that relies on it being there.

Apart from that, removing unused code is always good. ;-)

@juliantaylor
Copy link
Contributor Author

I don't see why ipython needs to ship 4000 lines of unused (and probably very old) code
third parties can embed it themself if they need it

@takluyver
Copy link
Member

I agree, but we have shipped that in releases up to now. So we need to warn anyone who might have been relying on it that they can't do that as of the next release. (And theoretically, if a lot of code relied on it, we'd deprecate it for a cycle first, but I can't imagine that will happen.)

@minrk
Copy link
Member

minrk commented Jun 4, 2012

Fernando pinged the list, but I would be surprised if anyone tres to make the case that this should still ship in IPython.

@tomspur
Copy link
Contributor

tomspur commented Jun 5, 2012

+1, great to see external/ shrinking.

@takluyver
Copy link
Member

OK, there were no objections on the mailing list (not that I expected any), and everyone seems happy about this, so I'm merging it now. Thanks, Julian.

takluyver added a commit that referenced this pull request Jun 6, 2012
Remove pyparsing and mglob from IPython.externals
@takluyver takluyver merged commit e9dcd18 into ipython:master Jun 6, 2012
@takluyver takluyver mentioned this pull request Jun 6, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Remove pyparsing and mglob from IPython.externals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

externals cleanup
4 participants