Fix error in test suite with ip.system() #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results for commit 789aae6 merged into master
Not available for testing: python2.6 |
| @@ -2210,7 +2210,7 @@ def system_raw(self, cmd): | |||
| # use piped system by default, because it is better behaved | |||
| system = system_piped | |||
|
|
|||
| def getoutput(self, cmd, split=True): | |||
| def getoutput(self, cmd, split=True, _depth=0): | |||
There was a problem hiding this comment.
I would expose depth without the underscore and document it publicly, it can come in handy for external users. And since this is an official method anyway, might as well.
|
Thanks for this! Other than my minor comment above, this is good to go. |
|
Test results for commit 34f8b22 merged into master
Not available for testing: python2.6 |
|
Sweet, thanks! Merging now... |
fperez
added a commit
that referenced
this pull request
Jun 10, 2012
Fix error in test suite with ip.system()
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix error in test suite with ip.system()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1878. Another case of looking the wrong depth through the stack.
There's still some other problem with the doctesting machinery -
ashould be turning up in the user namespace in this test, but it isn't. I've tried to understand the code to run doctests before, though, and it gives me a headache.