Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image message handler in ZMQTerminalInteractiveShell #1946

Merged
merged 24 commits into from Sep 29, 2012
Merged

Add image message handler in ZMQTerminalInteractiveShell #1946

merged 24 commits into from Sep 29, 2012

Commits on Aug 21, 2012

  1. Add image message handler in ZMQTerminalInteractiveShell 

    This change introduces handler for messages which contain image in
ZMQTerminalInteractiveShell.  This is useful, for example, when
connecting to the kernel in which pylab inline backend is activated.
Current image handler only supports PIL backend.
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    d232d49 View commit details
    Browse the repository at this point in the history

  2. Use io.BytesIO instead of StringIO

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    0cd1e6d View commit details
    Browse the repository at this point in the history

  3. Add more image handler backends 

    Also, trait of the image_handler configuration variable is changed to
Enum.
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    b69c268 View commit details
    Browse the repository at this point in the history

  4. Fix ZMQTerminalInteractiveShell.handle_rich_data 

    Shown only one image type.
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    f462822 View commit details
    Browse the repository at this point in the history

  5. Support passing image format to external program 

    1. In tempfile handler, extension of the file is properly set.
2. In stream and tempfile handler, {format} in command line is
   replaced with image format.
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    4a8f7c1 View commit details
    Browse the repository at this point in the history

  6. Make MIME preference order configurable

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    7cdae79 View commit details
    Browse the repository at this point in the history

  7. Redirect unused pipes to devnull

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    4528491 View commit details
    Browse the repository at this point in the history

  8. Use Python 2.6 compatible with statement

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    c2a1f15 View commit details
    Browse the repository at this point in the history

  9. Do not use NamedTemporaryFile in handle_image_tempfile 

    As external program may not be able to reopen the temporary file.

See:
http://docs.python.org/library/tempfile.html#tempfile.NamedTemporaryFile
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    beb6980 View commit details
    Browse the repository at this point in the history

  10. Fix failing test in Python 3

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    ce85550 View commit details
    Browse the repository at this point in the history

  11. Simplify handle_image_tempfile

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    fda5a33 View commit details
    Browse the repository at this point in the history

  12. Fix help for callable_image_handler

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    5e90b7a View commit details
    Browse the repository at this point in the history

  13. Add tests for image handlers

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    c43b749 View commit details
    Browse the repository at this point in the history

  14. Skip test for PIL handler when it is not available

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    ca773bf View commit details
    Browse the repository at this point in the history

  15. Encode to byte before base64.decodestring

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    7366f52 View commit details
    Browse the repository at this point in the history

  16. Python 3 compatibility fix on tests/writetofile.py

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    33978b3 View commit details
    Browse the repository at this point in the history

  17. Document tests/writetofile.py bit more

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    57462a9 View commit details
    Browse the repository at this point in the history

  18. Protect tests/writetofile.py from test discovery

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    61e38b8 View commit details
    Browse the repository at this point in the history

  19. Simplify check_handler_with_file

    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    2e36d88 View commit details
    Browse the repository at this point in the history

  20. "import PIL.Image" instead of "import PIL" 

    PIL.Image is actually a module.
    @tkf
    tkf committed Aug 21, 2012
    Configuration menu
    Copy the full SHA
    37580bc View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2012

  1. Fix test_no_call_by_default 

    raise_if_called was not used as intended
    @tkf
    tkf committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    449f64a View commit details
    Browse the repository at this point in the history

  2. Use assertEqual when possible

    @tkf
    tkf committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    e5c748e View commit details
    Browse the repository at this point in the history

  3. Use sys.executable instead of find_cmd('python')

    @tkf
    tkf committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    e9b4631 View commit details
    Browse the repository at this point in the history

  4. Open file after it is written

    @tkf
    tkf committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    235a478 View commit details
    Browse the repository at this point in the history