Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can func_defaults #1990

Merged
merged 2 commits into from Jul 26, 2012
Merged

can func_defaults #1990

merged 2 commits into from Jul 26, 2012

Conversation

minrk
Copy link
Member

@minrk minrk commented Jun 20, 2012

allows passing interactively defined functions as func_defaults

includes test

@minrk
Copy link
Member Author

minrk commented Jun 20, 2012

Even though I think this is quite minor and is tested, the potential for weirdness in serialization means I would not let this get in 0.13.

@fperez
Copy link
Member

fperez commented Jun 20, 2012

Sounds good, tagged explicitly for 0.14 then.

@minrk
Copy link
Member Author

minrk commented Jul 21, 2012

This is another one marked for 0.14, but actually done. It's quite simple, so if I get confirmation, I will merge.

@minrk
Copy link
Member Author

minrk commented Jul 21, 2012

Test results for commit 7cda0b9 (can't merge cleanly)
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing:

@minrk
Copy link
Member Author

minrk commented Jul 21, 2012

Since this touches pickleutil, I would rather merge #2069 first, which is more complicated and I would rather rebase this one than that.

allows passing interactively defined functions as func_defaults
@minrk
Copy link
Member Author

minrk commented Jul 26, 2012

Test results for commit 939db6e merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

@fperez
Copy link
Member

fperez commented Jul 26, 2012

Awesome, nice and clean. Merging now, thanks!

fperez added a commit that referenced this pull request Jul 26, 2012
Serialize func_defaults with canning machinery, which allows passing interactively defined functions as func_defaults.
@fperez fperez merged commit 7748dfa into ipython:master Jul 26, 2012
@minrk minrk deleted the func_defaults branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Serialize func_defaults with canning machinery, which allows passing interactively defined functions as func_defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants