Clarify generic message spec vs. Python message API in docs #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # but the Python implementation copies them to the top level. | ||
| 'msg_id' : uuid, | ||
| 'msg_type' : str, | ||
| 'parent_header' : dict |
There was a problem hiding this comment.
add trailing comma here, or syntax error will prevent highlighting.
|
Other than the one (or two, if you like) commas to add, this looks great. Thanks! |
|
Alright, the trailing commas were added. I also fixed a warning from the same file when building the docs. |
|
Terrific, thanks! |
minrk
added a commit
that referenced
this pull request
Jun 23, 2012
Clarify generic message spec vs. Python message API in docs
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Clarify generic message spec vs. Python message API in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussion in gh-2000, particularly this comment: #2000 (comment)