-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for %paste with special transformations #2015
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9791392
Move functions into magic methods.
fperez 0a8c65f
Refactored paste tests into proper class with setup/teardown.
fperez 656079a
Add failing test when pasting multiline strings with leading commas.
fperez fe1f5f6
Add second failing test, for source with trailing question marks.
fperez de336b3
Add robust email-quote-stripping function to text utilities.
fperez f494823
Fix continuation prompt in test.
fperez c8f0b16
Fix logic for longest_substring when only one input.
fperez 952285a
Fix tests for cpaste to use email quotes consistently in pasted blocks.
fperez 28ad69d
Properly clean up input for interactive pasting.
fperez 5e4113c
Fix missing self in cleanup method.
fperez 0c81344
Add full docstring to strip_email_quotes
fperez 0c2eef0
Fix newlines embedded in docstring for correct display and doctests.
fperez 85e9d88
Use `ip` consistently in tests to refer to IPython object as per review.
fperez File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this code is using
_ip
, while most of it seems to be usingip
. They're equivalent, but it would be cleaner to use one consistently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 85e9d88, thanks.