Skip to content

allows password and prefix for notebook #2073

Merged
merged 2 commits into from Jul 12, 2012

3 participants

@Carreau
IPython member
Carreau commented Jul 1, 2012

fixes #1997

@minrk
IPython member
minrk commented Jul 1, 2012

In the HTML, base_project_url should be used, not simply replacing '/' by ''.

@Carreau
IPython member
Carreau commented Jul 1, 2012

done.

@ellisonbg
IPython member

Was this feature just broken before?

@minrk
IPython member
minrk commented Jul 3, 2012

@ellisonbg yes, it has always been impossible to use url prefix and a password.

@Carreau
IPython member
Carreau commented Jul 3, 2012

You were not able to use both as the same time (at least not easily), you were redirected to the page without prefix, raising a 404.

@Carreau
IPython member
Carreau commented Jul 12, 2012

Is anybody against merging this ?
I'll merge in 24h+ is there is no objections.

@ellisonbg
IPython member

I'm Ok with this merging.

@minrk
IPython member
minrk commented Jul 12, 2012

looks good to me.

@Carreau
IPython member
Carreau commented Jul 12, 2012

Ok, let's not wait and merge then.

@Carreau Carreau merged commit 93c6c0f into ipython:master Jul 12, 2012
@Carreau Carreau added a commit to Carreau/ipython that referenced this pull request Jul 13, 2012
@Carreau Carreau allows both password and prefix for notebook
fixes #1997

backported to 0.13.1 from PR #2073
f089018
@minrk minrk added a commit that referenced this pull request Jul 21, 2012
@minrk minrk Backport PR #2073: allows password and prefix for notebook
fixes #1997
e868f46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.