allows password and prefix for notebook #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the HTML, base_project_url should be used, not simply replacing '/' by ''. |
|
done. |
|
Was this feature just broken before? |
|
@ellisonbg yes, it has always been impossible to use url prefix and a password. |
|
You were not able to use both as the same time (at least not easily), you were redirected to the page without prefix, raising a 404. |
|
Is anybody against merging this ? |
|
I'm Ok with this merging. |
|
looks good to me. |
|
Ok, let's not wait and merge then. |
Carreau
added a commit
that referenced
this pull request
Jul 12, 2012
Allows both password and prefix for notebook at the same time.
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Jul 13, 2012
fixes ipython#1997 backported to 0.13.1 from PR ipython#2073
minrk
added a commit
that referenced
this pull request
Jul 21, 2012
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Allows both password and prefix for notebook at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1997