-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show message on notebook list if server is unreachable #2159
Conversation
usefull when : server goes down, you don't notice it on dashboard restart on https, cookies is unvalid, autoreload don't work
var settings = { | ||
processData : false, | ||
cache : false, | ||
type : "GET", | ||
dataType : "json", | ||
success : $.proxy(this.list_loaded, this) | ||
success : $.proxy(this.list_loaded, this), | ||
error : $.proxy( function(){that.list_loaded([],null,null,{msg:"Error connecting to server."})},this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should put spaces after the commas here? simple style..
I'm not the one who should be reviewing JS codes, but it looks good to me and it's a sensible improvement. |
I'll trust myself on this one and merge, because I get caught too often today. |
show message on notebook list if server is unreachable
PR ipython#2159 introduced a bug preventing the notebook list from drawing
handle undefined param in notebooklist PR #2159 introduced a bug preventing the notebook list from drawing
Sorry about that, i'd fixed that on local but might have forgot to push... |
show message on notebook list if server is unreachable
PR ipython#2159 introduced a bug preventing the notebook list from drawing
handle undefined param in notebooklist PR ipython#2159 introduced a bug preventing the notebook list from drawing
usefull when :
server goes down, you don't notice it on dashboard
restart on https, cookies is unvalid, autoreload don't work