show message on notebook list if server is unreachable #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefull when : server goes down, you don't notice it on dashboard restart on https, cookies is unvalid, autoreload don't work
| var settings = { | ||
| processData : false, | ||
| cache : false, | ||
| type : "GET", | ||
| dataType : "json", | ||
| success : $.proxy(this.list_loaded, this) | ||
| success : $.proxy(this.list_loaded, this), | ||
| error : $.proxy( function(){that.list_loaded([],null,null,{msg:"Error connecting to server."})},this) |
There was a problem hiding this comment.
probably should put spaces after the commas here? simple style..
|
I'm not the one who should be reviewing JS codes, but it looks good to me and it's a sensible improvement. |
|
I'll trust myself on this one and merge, because I get caught too often today. |
Carreau
added a commit
that referenced
this pull request
Jul 20, 2012
show message on notebook list if server is unreachable
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Jul 21, 2012
PR ipython#2159 introduced a bug preventing the notebook list from drawing
minrk
added a commit
that referenced
this pull request
Jul 21, 2012
handle undefined param in notebooklist PR #2159 introduced a bug preventing the notebook list from drawing
|
Sorry about that, i'd fixed that on local but might have forgot to push... |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
show message on notebook list if server is unreachable
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
PR ipython#2159 introduced a bug preventing the notebook list from drawing
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
handle undefined param in notebooklist PR ipython#2159 introduced a bug preventing the notebook list from drawing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usefull when :
server goes down, you don't notice it on dashboard
restart on https, cookies is unvalid, autoreload don't work