Create a unique & temporary IPYTHONDIR for each testing group. #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results for commit bd7abfb merged into master
Not available for testing: python2.6 |
| env['IPYTHONDIR'] = IPYTHONDIR | ||
| # print >> sys.stderr, '*** CMD:', ' '.join(self.call_args) # dbg | ||
| subp = subprocess.Popen(self.call_args, env=env) | ||
| self.pids.append(subp.pid) |
There was a problem hiding this comment.
We should probably wait for #2204 to be merged first, and then update this to use that API, right?
|
Yes, exactly. Rebased and force pushed. |
|
Test results for commit 0b4fd4c merged into master
Not available for testing: python2.6 |
|
OK, all tests good, merging now. Thanks! |
fperez
added a commit
that referenced
this pull request
Jul 26, 2012
Create a unique & temporary IPYTHONDIR for each testing group. Following #2148 (unification of Windows / Unix code in iptest), and in progress towards #1880 (Add parallelism to iptest & test_pr), this pull request launches each iptest test group with a unique & temporary `IPYTHONDIR`. This has two benefits: * Insulates the test suite from any craziness in your own configuration. (Try adding `import sys; sys.exit()` to your config file...). * Allows multiple test suites to be launched in parallel without the worry of conflicts.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Create a unique & temporary IPYTHONDIR for each testing group. Following ipython#2148 (unification of Windows / Unix code in iptest), and in progress towards ipython#1880 (Add parallelism to iptest & test_pr), this pull request launches each iptest test group with a unique & temporary `IPYTHONDIR`. This has two benefits: * Insulates the test suite from any craziness in your own configuration. (Try adding `import sys; sys.exit()` to your config file...). * Allows multiple test suites to be launched in parallel without the worry of conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2148 (unification of Windows / Unix code in iptest), and
in progress towards #1880 (Add parallelism to iptest & test_pr), this
pull request launches each iptest test group with a unique & temporary
IPYTHONDIR.This has two benefits:
(Try adding
import sys; sys.exit()to your config file...).conflicts.