Tabs #2206

dlsun · 2012-07-26T05:53:50Z

Working for the most part. Some known issues:

Issues with tabs for brand new notebooks. Try adding a tab to a new notebook to see what I mean. The problems go away if you refresh the page just once.
The user is allowed rename a tab to blank. I tried to prevent this behavior by adding a blur event to the textbox (see tabmanager.js), but that event handler is circumvented if you click on the textbox more than once.

This reverts commit 3a1a244.

fperez · 2012-07-26T06:20:44Z

IPython/frontend/html/notebook/static/scripts/ipython_win_post_install.py

@@ -0,0 +1,151 @@
+#!python


This file got here by accident, it's not supposed to be here. In fact, the whole scripts/ directory under static/ shouldn't be there at all.

fperez · 2012-07-26T06:24:12Z

Hi @dlsun, this is great to see! This PR will probably need some history cleanup before merging, because unfortunately the current history is a bit of a mess and it touches files that shouldn't have been modified in the first place. But don't worry: we'll be happy to give you a hand with that, the first priority is to get the (extremely important) tab functionality working robustly, we're very excited to see progress on this front.

We'll be playing with this over the next few days and providing you with more specific feedback. Thanks for contributing!

dlsun · 2012-07-26T06:47:06Z

Yes, I'm very sorry about the misplaced files and the messy history -- I
had a couple of git mishaps along the way. (I essentially created a git
repository inside a subdirectory of main git repository without realizing
it.)

Please let me know what I need to do to clean the git history; it's
something I would like to learn!

fperez · 2012-07-26T06:53:32Z

On Wed, Jul 25, 2012 at 11:47 PM, dlsun
reply@reply.github.com
wrote:

Yes, I'm very sorry about the misplaced files and the messy history -- I
had a couple of git mishaps along the way. (I essentially created a git
repository inside a subdirectory of main git repository without realizing
it.)

Please let me know what I need to do to clean the git history; it's
something I would like to learn!

You'll want to familiarize yourself with 'git rebase'. The tutorials
at github are in general pretty good, and I have some additional links
to git resources here: http://fperez.org/py4science/git.html

You'll want to rebase this branch, removing the commits that are
irrelevant and leaving no merges from the main repo, so that we can
evaluate only your new changes in isolation from anything else that
happened in the project.

You can make a 'backup' branch easily by creating a new branch off
this one in your local repo before starting the rebase process. That
way if you make a mistake, it's trivial to find again the point where
you started (it's always possible to do so, as git doesn't destroy
your data, but having a named backup makes it easiear and less scary).

Carreau · 2012-07-26T11:48:05Z

looks cool.
2 comments.

Please indent with space to be consistent with the rest of the code
Issues with new notebooks are due to 'document ready' called twice. No idea why.

I'll look at the code later.

Carreau · 2012-07-26T14:38:38Z

IPython/frontend/html/notebook/static/js/menubar.js

+	});
+	this.element.find('#insert_worksheet_below').click(function() {
+	    IPython.notebook.insert_worksheet_below('New Sheet');
+	});
        this.element.find('#insert_cell_above').click(function () {


I would change bellow/above for left/right, what do you think ?

Carreau · 2012-07-26T15:16:59Z

That's a lot a code... I didn't read it all yet.
The selection of element in the DOM seem sometime complicated, but I need to understand it better first.
I'm not event sure about all the comment I made.
I read it on github and it seem that it use 2spaces tabs, so it's hard to read.

dlsun · 2012-07-26T16:32:47Z

Thanks for all the suggestions.

@Carreau, I like many of your Javascript suggestions, although most of the functions to handle the worksheets are adapted versions of existing functions that were handling the cells, so if we change the Javascript for the worksheets we should also change it for the cells, for consistency.

I agree that getting the worksheets is a major pain. The problem is that when you reorder the tabs, the div elements corresponding to the panels don't get reordered, so when you save the notebook, it saves the worksheets in the original order. The messy code that I have is just to get the ordering of the tabs, and then fetch each div element in that order. If anyone has a better way of doing this, I'd be interested to know.

I'll rebase tonight.

Carreau · 2012-07-26T16:39:01Z

@Carreau, I like many of your Javascript suggestions, although most of the functions to handle the worksheets are adapted versions of existing functions that were handling the cells, so if we change the Javascript for the worksheets we should also change it for the cells, for consistency.

Sure, but it would be better to do it separately, this PR is big enough.

I agree that getting the worksheets is a major pain. The problem is that when you reorder the tabs, the div elements corresponding to the panels don't get reordered, so when you save the notebook, it saves the worksheets in the original order. The messy code that I have is just to get the ordering of the tabs, and then fetch each div element in that order. If anyone has a better way of doing this, I'd be interested to know.

Oh? you can drag to reorder ? I'll try tomorrow.

Carreau · 2012-07-28T11:10:48Z

Did you had a change to rebase and convert the tabs to spaces ?

dlsun · 2012-07-29T01:44:49Z

@Carreau, I've cleaned up the history (I ended up starting from a clean copy of master and replacing only the files that needed to be changed), and replaced tabs by spaces.

Carreau · 2012-07-29T10:41:37Z

hi,
Thanks for the rebase, there is still a small conflict thought.
Otherwise this is broken for me see capture :

I have no way to scroll the menubar back visible, and the pager is below the cells.

Also imho, tabs take a lot a space and I would be greate to have a way to hide them and/or make them scroll with the notebook and be hidden below the menubar. Not sure about this one.

Carreau · 2012-07-29T10:46:24Z

IPython/frontend/html/notebook/static/js/layoutmanager.js

@@ -50,8 +50,10 @@ var IPython = (function (IPython) {
        $('div#pager').height(pager_height);
        if (IPython.pager.expanded) {
            $('div#notebook').height(app_height-pager_height-pager_splitter_height);
+	    $('div.panel').height(app_height-pager_height-pager_splitter_height);


Sorry i'll nitpick...
wrong indent level.

Carreau · 2012-07-29T14:58:46Z

the problem at first load is due to this
I think it's here only for new notebook i'll open a issue to change this to a real redirect.

tkf · 2012-08-19T23:41:22Z

IPython/frontend/html/notebook/static/js/worksheet.js

+
+        $([IPython.events]).on('set_dirty.Worksheet', function (event, data) {
+            that.dirty = data.value;
+        });


What happens when there are multiple worksheets? Triggering set_dirty.Worksheet sets the dirty flag for all worksheets?

Same question for set_next_input.Worksheet. What happens if data.cell is in another worksheet?

tkf · 2012-08-19T23:44:48Z

Just curious. Why IPython.events uses method_like_name.ClassName? Is it some jQuery specific stuff? I always wonder why it does not use ClassName.method_like_name.

Carreau · 2012-09-28T15:09:14Z

Trying to revive old PRs.
Any progress on this one ?

ellisonbg · 2012-10-03T19:54:34Z

I haven't dived into the code yet, but have some general comments:

We are wanting to quickly move to using bootstrap, rather than jquery UI. @Carreau do you think we should consider eliminating all jQuery UI usage, or should we make the transition more slowly? I am wondering if we want to implement the tab UI using bootstrap from the start.
We will need a complex set of capabilities for the tab UI: renaming, new, moving, removing, cut/copy/paste between worksheets, etc. I am not excited about adding lots of visual complexity to our UI to implement this. What about a simple CLI for manipulating notebook documents. Something like `movecell(1.1,2.3)' = move cell 1 ws 1 to below cell 3 ws 2 instead? We could do a lot of powerful things with something like that as well.
Tabs are a great solution when there are only a few of them. Whern there are more it gets tough. Can we think of a tabbing UI that scales better?

Carreau · 2012-10-04T06:15:52Z

I haven't dived into the code yet, but have some general comments:

We are wanting to quickly move to using bootstrap, rather than jquery UI. @Carreau do you think we should consider eliminating all jQuery UI usage, or should we make the transition more slowly? I am wondering if we want to implement the tab UI using bootstrap from the start.

I would go slowly.
To start, we can rename our jqueryUI.css to a .less file and include it in bootstrap so that it compiles with less as mixins and get rid of it progressively.

We will need a complex set of capabilities for the tab UI: renaming, new, moving, removing, cut/copy/paste between worksheets, etc. I am not excited about adding lots of visual complexity to our UI to implement this. What about a simple CLI for manipulating notebook documents. Something like `movecell(1.1,2.3)' = move cell 1 ws 1 to below cell 3 ws 2 instead? We could do a lot of powerful things with something like that as well.

+1 If I understand correctly custom toolbar wil allow people to customize.

Tabs are a great solution when there are only a few of them. Whern there are more it gets tough. Can we think of a tabbing UI that scales better?

Some things like tabs have to be visible, but can be smaller.
Why not a shortcut to hide all UI but toolbar/ restore UI ?

ellisonbg · 2012-12-04T22:26:14Z

This is important work that has been sitting for a while, but it needs to be rebased. It also needs further review. @dlsun can re rebase this so review can continue?

dlsun · 2012-12-05T02:40:28Z

I would love to see this worked into the codebase, but unfortunately I no
longer have time to work on it. Perhaps someone could take over (or even
start from scratch -- I didn't change too much code).

On Tue, Dec 4, 2012 at 2:26 PM, Brian E. Granger
notifications@github.comwrote:

This is important work that has been sitting for a while, but it needs to
be rebased. It also needs further review. @dlsunhttps://github.com/dlsuncan re rebase this so review can continue?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2206#issuecomment-11018592.

ellisonbg · 2012-12-05T19:55:57Z

OK I am going to close this. We are using issue #1905 to track progress on this feature and have linked to this PR for future work.

Carreau · 2013-02-10T10:22:47Z

Do not continue work on this before speeking to the core developers.
Worksheet data structure might be removed.

Dennis and others added 4 commits June 18, 2012 18:44

reset

3a1a244

Revert "reset"

a086c99

This reverts commit 3a1a244.

Update master

38df12d

Merge branch 'master' of github.com:dlsun/ipython

c15f92e

fperez reviewed Jul 26, 2012
View reviewed changes

Carreau reviewed Jul 26, 2012
View reviewed changes

Dennis added 3 commits July 28, 2012 18:27

Implemented tabs for worksheets

5a88ed8

Reverted README file to the original

62af88e

Replaced tabs by spaces

2932aab

Carreau reviewed Jul 29, 2012
View reviewed changes

Carreau mentioned this pull request Jul 29, 2012

Change NewNotebook handler to use 30x redirect #2217

Closed

bfroehle mentioned this pull request Jul 31, 2012

Use redirect for new notebooks #2218

Merged

tkf reviewed Aug 19, 2012
View reviewed changes

This was referenced Oct 5, 2012

Do not destroy valid notebooks #2470

Closed

Support worksheets ("tabs") tkf/emacs-ipython-notebook#67

Closed

ellisonbg mentioned this pull request Dec 5, 2012

Expose UI for worksheets within each notebook #1905

Closed

ellisonbg closed this Dec 5, 2012

jakebiesinger mentioned this pull request Feb 9, 2013

WIP: Manual rebase of @dlsun's tabs implementation #2907

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tabs #2206

Tabs #2206

dlsun commented Jul 26, 2012

fperez Jul 26, 2012

fperez commented Jul 26, 2012

dlsun commented Jul 26, 2012

fperez commented Jul 26, 2012

Carreau commented Jul 26, 2012

Carreau Jul 26, 2012

Carreau commented Jul 26, 2012

dlsun commented Jul 26, 2012

Carreau commented Jul 26, 2012

Carreau commented Jul 28, 2012

dlsun commented Jul 29, 2012

Carreau commented Jul 29, 2012

Carreau Jul 29, 2012

Carreau commented Jul 29, 2012

tkf Aug 19, 2012

tkf commented Aug 19, 2012

Carreau commented Sep 28, 2012

ellisonbg commented Oct 3, 2012

Carreau commented Oct 4, 2012

ellisonbg commented Dec 4, 2012

dlsun commented Dec 5, 2012

ellisonbg commented Dec 5, 2012

Carreau commented Feb 10, 2013

Tabs #2206

Tabs #2206

Conversation

dlsun commented Jul 26, 2012

fperez Jul 26, 2012

Choose a reason for hiding this comment

fperez commented Jul 26, 2012

dlsun commented Jul 26, 2012

fperez commented Jul 26, 2012

Carreau commented Jul 26, 2012

Carreau Jul 26, 2012

Choose a reason for hiding this comment

Carreau commented Jul 26, 2012

dlsun commented Jul 26, 2012

Carreau commented Jul 26, 2012

Carreau commented Jul 28, 2012

dlsun commented Jul 29, 2012

Carreau commented Jul 29, 2012

Carreau Jul 29, 2012

Choose a reason for hiding this comment

Carreau commented Jul 29, 2012

tkf Aug 19, 2012

Choose a reason for hiding this comment

tkf commented Aug 19, 2012

Carreau commented Sep 28, 2012

ellisonbg commented Oct 3, 2012

Carreau commented Oct 4, 2012

ellisonbg commented Dec 4, 2012

dlsun commented Dec 5, 2012

ellisonbg commented Dec 5, 2012

Carreau commented Feb 10, 2013