New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI For Metadata #2333
UI For Metadata #2333
Conversation
Hi, Fell free to reopen this PR whenever you want or contact us if you have any questions. Thanks for contributing. I ll reopen later when times come. |
Reopening since #2127 has been merged. |
Now that #2127 went in, do you want to add the button? That way we can play with it 'for real'... |
Yes, I'm working on it, but I'm leaving for conference on tuesday and just finished my poster. Still here is a prototype which toggle between "Nothing Special" and "Slide Start". There is a button in the toolbar to toggle the per cell menubar. Pinging @ellisonbg, are you more interested in making this ready for merging, or are you Ok to make your PyData Presentation for a not yet merge Branch ? If the later, I would hard code most on the stuff on this branch and start working on the Presentation Mode itself. |
Ok, the basic stuff should work for all kinds of cells. metadata look like
And the 2 properties can be toggled in one click, and survives save and reload. |
OK, https://github.com/Carreau/ipython/tree/slideshow_metadata Click on the 'image' button in the toolbar, before the
then,
This push a new To control the slide transition you have to click on the 'enable slide control' in the new toolbar on the top. The 'stop' button is more a 'Pause' button, as if you start the slideshow again, you will get back to where you where before. I'll redo the all thing later, but right now and won't have time. |
And now there is a stop/pause button, with the first you will start again from first slide, with the second, you will start where you left from. The icon to toggle the metadata toolbar is now Done for today. |
Slideshow mode is great! Is there any documentation for it? (what does the In/Out button do, what does Group Stop / Slide Stop mean?) Also, have you ever tried applying styling to your slides? http://wiki.ipython.org/Cookbook/Styling_Notebook only seems to work for the UI component. |
From my phone, so short: In/Out: show only input; show only output; show in then out.; 2 at the same Group/slide : is it a start of a new slide or a step in showing the current This is mainly an experimental branch so it is not documented and wont stay
|
As for the css; we have custon element. You can override in
|
Re: experimental - it will be incredibly useful, so I hope you continue development! Re: css, thanks; looks like the full directions for that process are here: http://mail.scipy.org/pipermail/ipython-user/2012-August/010997.html. However, I get the |
Yes, it will be part of ipython.
This is because the server does not see you file, there is a placeholder file to avoid 404. Did you restart the server? What is the full path of the css file you added ? |
Yes, I restarted the server. Full path is: FYI, I'm running from commit faedbd7 on the |
Yep, you are right, this branch is a little old and does not have custom css. This one should be a little more recent : |
slideshow_mode is the proof of concept branch. You should also have a IIRC, in some branches the transition can be edited with the metadata toolbar, in the oldes one you should put |
OK, great! I will go ahead and use it - is this Issue a good place for feedback, or should I open independent issues in your fork? Last question on css: Is it possible to override the UI css using the |
|
Yes any file in It should be possible to add a class to |
You need to load the extension cf comment above (#2333 (comment)) |
|
Ah right, I just made a silly mistake not doing |
@Carreau - Thanks for your work on this Matthias. We're going to be using slideshow_mode tomorrow in the Supercomputing presentation. We're going to hold off on the advanced metadata stuff, but I'll try to collect feedback from both instructors and students about how they feel things went. |
More initial feedback. The lack of a slide navigator is a real show-stopper right now for working with and debugging large slide shows. It would be great if you could click the little [x/X] button indicating the current slide and choose to jump to a slide from the dropdown. |
'flase' is true while false is false
update docs
And change text.
Everything should be fixed, rebased on master to avoid stupid conflict. Css could be perfected, but if we move to bootstrap soon, in anyway most of this would have to be re-done. So I would prefer not to fight for pixel perfect alignment now. |
var example_preset = [] | ||
example_preset.push('default.rawedit'); | ||
|
||
CellToolbar.register_preset('default',example_preset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's capitalize default
-> Default
as the other menu items are capitalized.
Hmm, I can't seem to load the example preset from the new location. I am including the following in my
Am I missing something? |
CellToolbar.register_callback('example.help',add_simple_dialog_button) | ||
example_preset.push('example.help') | ||
|
||
CellToolbar.register_preset('example',example_preset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's capitalize "Example" here as well.
Nop, fixed now. |
Awesome, looks great! I am merging as all the comment have been addressed. Thanks for your patient work on this one, wish I could buy you a beer this evening! |
Yeepeee after 5 month ! It was a hard one ! Thanks for you careful review ! |
Yes, I wish I could have spent more time reviewing to get it in faster, but On Mon, Jan 14, 2013 at 12:05 PM, Bussonnier Matthias <
Brian E. Granger |
El 14/01/13 17:05, Bussonnier Matthias escribió:
Thanks both for the hard work!!! |
UI For Metadata
This a prototype to edit metadata.
right now you need to execute
``` %%javascript #execute to toggle header to edit metadata of cell $('body').toggleClass('editmetaon') ```To see the UI change.
I'll add a button to the toolbar to do so once #2127 is merged.
looks like
Cell "header" are togglable by above command, and clicking on "raw edit" bring the modal editor.
My question is what kind of API do we want to add other buttons to the cell header/toolbar.
Obviously if an extension want to add a button, the button needs to be be added to all the current cell of a certain type.
Do we allows extension to be loaded at any time, or do we says that some stuff can only be extended if the extension is loded at notebook load time?
And we also need maybe an event to say that the metadata have changed.
Update :
see this comment
To see how to enable.