qtconsole: Create a prompt newline by inserting a new block (w/o formatting) #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for the fix. |
epatters
added a commit
that referenced
this pull request
Sep 6, 2012
qtconsole: Create a prompt newline by inserting a new block (w/o formatting)
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
qtconsole: Create a prompt newline by inserting a new block (w/o formatting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we inserted a
'\n'to create a newline before a prompt. This, however proved fragile as in code likethe newline inserted a new list item instead of a new paragraph.
As far as I can tell the correct notion here is a new "block" which seems to behave like an HTML paragraph.
Closes #2314