skip find_cmd when setting up script magics #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find_cmd was slow, and probably unnecessary anyway.
More relevant now that we register default script magics that probably don't exist.
|
@jasongrout, would you mind giving this PR a quick test? It would be good to know if it improves your startup situation in any significant way... |
|
It does seem to make a difference. Thanks! |
|
to be precise, it cuts our startup time in about 1/2. |
|
As it seem to do it's job, and speed up startup a lot, i'm going to merge this guy. |
Carreau
added a commit
that referenced
this pull request
Sep 29, 2012
skip find_cmd when setting up script magics find_cmd was slowing down process startup, and probably unnecessary anyway.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
skip find_cmd when setting up script magics find_cmd was slowing down process startup, and probably unnecessary anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_cmd was slowing down process startup, and probably unnecessary anyway.