Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylab_not_importable: Catch all exceptions, not just RuntimeErrors. #2668

Merged
merged 1 commit into from
Dec 8, 2012

Conversation

bfroehle
Copy link
Contributor

@bfroehle bfroehle commented Dec 7, 2012

This catches situations when pylab isn't installed or fails for another
reason like:

ImportError: No module named backend_tkagg

Closes gh-2646.

This catches situations when `pylab` isn't installed or fails for
another reason like:

  ImportError: No module named backend_tkagg

Closes ipythongh-2646.
@takluyver
Copy link
Member

pylab is installed as part of matplotlib, so that case ought to be caught by the @skipif_not_matplotlib decorators already used in that file. Do we know under what conditions the 'No module named backend_tkagg' occurs?

The change looks fine, I just want to understand what the code is up to.

@bfroehle
Copy link
Contributor Author

bfroehle commented Dec 8, 2012

I suspect the error would happen in cases where your Python installation was compiled without Tk (i.e., without the Tkinter module). This prevents matplotlib from building the tkagg backend.

-Brad

@takluyver
Copy link
Member

That makes sense. Go ahead and merge, then.

On 8 December 2012 22:10, Bradley M. Froehle notifications@github.comwrote:

I suspect the error would happen in cases where your Python installation
was compiled without Tk (i.e., without the Tkinter module). This prevents
matplotlib from building the tkagg backend.

-Brad


Reply to this email directly or view it on GitHubhttps://github.com//pull/2668#issuecomment-11164386.

bfroehle added a commit that referenced this pull request Dec 8, 2012
pylab_not_importable: Catch all exceptions, not just RuntimeErrors.
@bfroehle bfroehle merged commit 941d9af into ipython:master Dec 8, 2012
minrk added a commit that referenced this pull request Mar 5, 2013
…st RuntimeErrors.

This catches situations when `pylab` isn't installed or fails for another
reason like:

  ImportError: No module named backend_tkagg

Closes gh-2646.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
pylab_not_importable: Catch all exceptions, not just RuntimeErrors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylab_not_importable
2 participants