Skip to content

pylab_not_importable: Catch all exceptions, not just RuntimeErrors. #2668

Merged
merged 1 commit into from Dec 8, 2012

2 participants

@bfroehle
bfroehle commented Dec 7, 2012

This catches situations when pylab isn't installed or fails for another
reason like:

ImportError: No module named backend_tkagg

Closes gh-2646.

@bfroehle bfroehle pylab_not_importable: Catch all exceptions, not just RuntimeErrors.
This catches situations when `pylab` isn't installed or fails for
another reason like:

  ImportError: No module named backend_tkagg

Closes gh-2646.
60f6674
@takluyver
IPython member

pylab is installed as part of matplotlib, so that case ought to be caught by the @skipif_not_matplotlib decorators already used in that file. Do we know under what conditions the 'No module named backend_tkagg' occurs?

The change looks fine, I just want to understand what the code is up to.

@bfroehle
@takluyver
IPython member
@bfroehle bfroehle merged commit 941d9af into ipython:master Dec 8, 2012

1 check passed

Details default The Travis build passed
@minrk minrk added a commit that referenced this pull request Mar 5, 2013
@minrk minrk Backport PR #2668: pylab_not_importable: Catch all exceptions, not ju…
…st RuntimeErrors.

This catches situations when `pylab` isn't installed or fails for another
reason like:

  ImportError: No module named backend_tkagg

Closes gh-2646.
5f41d9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.