can interactively defined classes #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried your branch and I confirm it fixes the notebook example I submitted in #2754. Thanks |
|
This code has tests that pass, and the user confirmed it fixes the issue. I would go ahead and merge. |
|
I don't know the change-log policy for the IPython project but should not that be documented somewhere, maybe in the whats new section of the doc? |
|
For little bugfixes like this, I think the generated GitHub summary that goes in whatsnew is sufficient. |
minrk
added a commit
that referenced
this pull request
Jan 11, 2013
can interactively defined classes *Only* interactively defined classes are canned. closes #2754
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
can interactively defined classes *Only* interactively defined classes are canned. closes ipython#2754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as proposed in #2754
Only interactively defined classes are canned.
closes #2754