avoid comparison error in dictdb hub history #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in rare situations, display data can arrive at the Hub before the execution request, in which case `submitted` is undefined. should address ipython#2821, but I need to see Jenkins succeed, since that is the only place this comes up.
|
The error has disappeared today, even though this hasn't been merged yet. If you think that this ought to fix it, shall we merge this and give it a few days to see if the error reappears? |
|
That sounds like the right thing to do. It takes a pretty weird sequence of events to cause this to happen, |
minrk
added a commit
that referenced
this pull request
Jan 23, 2013
avoid comparison error in dictdb hub history in rare situations, display data can arrive at the Hub before the execution request, in which case `submitted` is undefined. should address #2821, but I need to see Jenkins succeed, since that is the only place this comes up.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
avoid comparison error in dictdb hub history in rare situations, display data can arrive at the Hub before the execution request, in which case `submitted` is undefined. should address ipython#2821, but I need to see Jenkins succeed, since that is the only place this comes up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in rare situations, display data can arrive at the Hub before the execution
request, in which case
submittedis undefined.should address #2821, but I need to see Jenkins succeed, since that is the
only place this comes up.