Don't add logging handler if one already exists. #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a default handler already exists, it is expected that IPython is embedded in an application that uses logging. In that case IPython should not provide its own logging handler, but rely on the embedding application's handlers.
| The default is to log to stdout using a StreaHandler. The log level | ||
| starts at loggin.WARN, but this can be adjusted by setting the | ||
| ``log_level`` attribute. | ||
| The default is to log to stdout using a StreamHandler, if no default |
There was a problem hiding this comment.
do you want to fix this typo as well? The default is stderr, not stdout.
|
thanks, merging. |
minrk
added a commit
that referenced
this pull request
Feb 13, 2013
Don't add logging handler if one already exists.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't add logging handler if one already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a default handler already exists, it is expected that IPython is embedded in an application that uses logging. In that case IPython should not provide its own logging handler, but rely on the embedding application's handlers.
Use case: remove the "To connect another client to this kernel..." messages when embedding IPython in an application that uses logging (by providing a filter to the root handler).