Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add logging handler if one already exists. #2917

Merged
merged 2 commits into from Feb 13, 2013
Merged

Don't add logging handler if one already exists. #2917

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeedc16
Don't add logging handler if one already exists.
anntzer Feb 12, 2013
8d95e66
Fix docstring of _log_default.
anntzer Feb 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 11 additions & 3 deletions IPython/config/application.py
View file
Open in desktop
Expand Up @@ -140,12 +140,20 @@ def _log_level_changed(self, name, old, new):
def _log_default(self):
"""Start logging for this application.

The default is to log to stdout using a StreaHandler. The log level
starts at loggin.WARN, but this can be adjusted by setting the
``log_level`` attribute.
The default is to log to stderr using a StreamHandler, if no default
handler already exists. The log level starts at logging.WARN, but this
can be adjusted by setting the ``log_level`` attribute.
"""
log = logging.getLogger(self.__class__.__name__)
log.setLevel(self.log_level)
_log = log # copied from Logger.hasHandlers() (new in Python 3.2)
while _log:
if _log.handlers:
return log
if not _log.propagate:
break
else:
_log = _log.parent
if sys.executable.endswith('pythonw.exe'):
# this should really go to a file, but file-logging is only
# hooked up in parallel applications
Expand Down