Don't die if stderr/stdout do not support set_parent() #2925 #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
set_parent is also called on L576-577 |
If the user redirects the streams to a file for example, the kernel would raise an exception because file objects do not have set_parent defined, unlike ipython's OutStream. This happens even if the user does this in a spawned thread.
|
thank you, fixed. |
|
simple enough, merging. Thanks! |
minrk
added a commit
that referenced
this pull request
Feb 13, 2013
Don't die if stderr/stdout do not support set_parent() If the user redirects the streams to a file for example, the kernel would raise an exception because file objects do not have set_parent defined, unlike ipython's OutStream. This happens even if the user does this in a spawned thread. closes #2925
|
45 minutes from hitting a bug to upstream fixed. This is why I love open-source. |
|
it's nice when it works out. |
ghost
deleted the
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't die if stderr/stdout do not support set_parent() If the user redirects the streams to a file for example, the kernel would raise an exception because file objects do not have set_parent defined, unlike ipython's OutStream. This happens even if the user does this in a spawned thread. closes ipython#2925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user redirects the streams to a file for example,
the kernel would raise an exception because file
objects do not have set_parent defined, unlike ipython's
OutStream.
This happens even if the user does this in a spawned thread.
closes #2925