Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused print notebook view #3235

Merged
merged 8 commits into from
May 1, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 0 additions & 13 deletions IPython/frontend/html/notebook/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,19 +380,6 @@ def get(self, notebook_id):
)


class PrintNotebookHandler(IPythonHandler):

@authenticate_unless_readonly
def get(self, notebook_id):
if not self.notebook_manager.notebook_exists(notebook_id):
raise web.HTTPError(404, u'Notebook does not exist: %s' % notebook_id)
self.write( self.render_template('printnotebook.html',
project=self.project,
notebook_id=notebook_id,
kill_kernel=False,
mathjax_url=self.mathjax_url,
))

#-----------------------------------------------------------------------------
# Kernel handlers
#-----------------------------------------------------------------------------
Expand Down
6 changes: 2 additions & 4 deletions IPython/frontend/html/notebook/notebookapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@
ProjectDashboardHandler, NewHandler, NamedNotebookHandler,
MainKernelHandler, KernelHandler, KernelActionHandler, IOPubHandler, StdinHandler,
ShellHandler, NotebookRootHandler, NotebookHandler, NotebookCopyHandler,
AuthenticatedFileHandler, PrintNotebookHandler,
MainClusterHandler, ClusterProfileHandler, ClusterActionHandler,
FileFindHandler, NotebookRedirectHandler,
AuthenticatedFileHandler, MainClusterHandler, ClusterProfileHandler,
ClusterActionHandler, FileFindHandler, NotebookRedirectHandler,
)
from .nbmanager import NotebookManager
from .filenbmanager import FileNotebookManager
Expand Down Expand Up @@ -154,7 +153,6 @@ def __init__(self, ipython_app, kernel_manager, notebook_manager,
(r"/%s" % _notebook_id_regex, NamedNotebookHandler),
(r"/%s" % _notebook_name_regex, NotebookRedirectHandler),
(r"/%s/copy" % _notebook_id_regex, NotebookCopyHandler),
(r"/%s/print" % _notebook_id_regex, PrintNotebookHandler),
(r"/kernels", MainKernelHandler),
(r"/kernels/%s" % _kernel_id_regex, KernelHandler),
(r"/kernels/%s/%s" % (_kernel_id_regex, _kernel_action_regex), KernelActionHandler),
Expand Down
2 changes: 1 addition & 1 deletion IPython/frontend/html/notebook/static/css/style.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions IPython/frontend/html/notebook/static/js/menubar.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ var IPython = (function (IPython) {
notebook_id + '?format=py';
window.location.assign(url);
});
this.element.find('button#print_notebook').click(function () {
IPython.print_widget.print_notebook();
});
this.element.find('#kill_and_exit').click(function () {
IPython.notebook.kernel.kill();
setTimeout(function(){window.close();}, 200);
Expand Down
30 changes: 0 additions & 30 deletions IPython/frontend/html/notebook/static/js/printnotebookmain.js

This file was deleted.

10 changes: 0 additions & 10 deletions IPython/frontend/html/notebook/static/less/printnotebook.less

This file was deleted.

1 change: 0 additions & 1 deletion IPython/frontend/html/notebook/static/less/style.less
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
@import "variables.less";
@import "flexible-box-model.less";
@import "notebook.less";
@import "printnotebook.less";
@import "renderedhtml.less";
@import "tooltip.less";
81 changes: 0 additions & 81 deletions IPython/frontend/html/notebook/templates/printnotebook.html

This file was deleted.