-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: "python ABS/PATH/TO/ipython.py" fails #3276
Conversation
Is the Also, there is a small precedent in the Python community to call this __directory__ = os.path.dirname(__file__) |
No, abspath is not necessary but I tend to do this because it works even if you live with evil functions which changes directory. Also I don't have strong opinion about the naming so it is OK to rename it to BTW, what is the policy for merging PRs? Does it need more than two reviewers or one reviewer is fine? I just quickly checked the wiki but there is not much info. If one reviewer is fine I would just fix them right away, because this kind of stuff is mostly about preference and I think comitters preference must be weighted than mine. But if more than two reviewers are needed, waiting for another comment is better because other reviewer might have different opinion. I am just being lazy :) |
I changed it to If I may say so I really don't like exec* at all... |
Also for reference, I think we are going to remove |
Also, please use standard |
There are decisions to make before I can make a change. Please give me your choices. I wrote my opinion in the above comment.
|
Thanks! |
The following line in setupbase.py was the problem. It assumes that your CWD is always at the repository root. This patch removes this assumption. execfile(pjoin('IPython','core','release.py'), globals())
Rebased. Thanks for your review! |
OK, looks good now. Thanks! Merging now. |
Remove assumption that setup is being run from repo root.
Remove assumption that setup is being run from repo root.
The following line in setupbase.py was the problem. It assumes
that your CWD is always at the repository root. This patch removes
this assumption.