Fix: "python ABS/PATH/TO/ipython.py" fails

[tkf]

The following line in setupbase.py was the problem. It assumes
that your CWD is always at the repository root. This patch removes
this assumption.

execfile(pjoin('IPython','core','release.py'), globals())

[bfroehle]

Is the abspath necessary?

Also, there is a small precedent in the Python community to call this __directory__, i.e,:

__directory__ = os.path.dirname(__file__) 

[tkf]

No, abspath is not necessary but I tend to do this because it works even if you live with evil functions which changes directory. Also I don't have strong opinion about the naming so it is OK to rename it to __directory__ (but I don't know if it is a good idea to define variable with double underscores which is not in some kind of spec).

BTW, what is the policy for merging PRs? Does it need more than two reviewers or one reviewer is fine? I just quickly checked the wiki but there is not much info. If one reviewer is fine I would just fix them right away, because this kind of stuff is mostly about preference and I think comitters preference must be weighted than mine. But if more than two reviewers are needed, waiting for another comment is better because other reviewer might have different opinion. I am just being lazy :)

[function2]

I changed it to
-execfile(pjoin('IPython','core','release.py'), globals())
+execfile(pjoin(os.path.dirname(sys.argv[0]),'IPython','core','release.py'), globals())

If I may say so I really don't like exec* at all...

[minrk]

Also for reference, I think we are going to remove ipython.py before 1.0.

[ellisonbg]

Also, please use standard variable_names rather than all caps. With ipython.py being removed, what do we want to do with this one?

[tkf]

There are decisions to make before I can make a change. Please give me your choices. I wrote my opinion in the above comment.

1. repo_root or __directory__
2. Should we use abspath?

[fperez]

1. Use repo_root: no caps, and there's always a chance Python will in the future define __directory__ for something, so let's stay away from that.
2. Do use abspath: it's a good safety to use in this kind of code.
3. There's a conflict right now that needs fixing, should be an easy rebase.

Thanks!

[tkf]

Rebased. Thanks for your review!

[fperez]

OK, looks good now. Thanks! Merging now.