Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ipython.py entry point #3284

Merged
merged 4 commits into from May 9, 2013
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented May 6, 2013

it's weird and confusing and not maintained well.

Adds a python -m IPython entry point in its place, which should work anywhere.

@rkern
Copy link
Contributor

rkern commented May 6, 2013

I believe IPython/__main__.py would be the preferred way to implement python -m IPython since Python 2.6.

@minrk
Copy link
Member Author

minrk commented May 6, 2013

Of course, that's already there, so I just removed my change. I don't know why I didn't check first. Thanks!

@tkf
Copy link
Contributor

tkf commented May 6, 2013

FYI, ipython.py and -m IPython are not equivalent as it seems IPython.main does not call update_submodules.

@minrk
Copy link
Member Author

minrk commented May 6, 2013

Nor should it, really. The point is that ipython.py is a little-used entry point that is not worth maintaining. Also python -m IPython notebook will do what it should regarding submodules / messages after #3275 is merged.

@fperez
Copy link
Member

fperez commented May 7, 2013

For the record, I'm +1 on this cleanup. Let's let it simmer for another day or two, to give others a chance to pitch in, and unless a valid objection arises, we can merge. Thanks!

@bfroehle
Copy link
Contributor

bfroehle commented May 7, 2013

Fine with me!

@bfroehle
Copy link
Contributor

bfroehle commented May 7, 2013

Also need to remove ipython.py from MANIFEST.IN, and fix examples/core/ipython_here_shell_extension.reg.

@minrk
Copy link
Member Author

minrk commented May 7, 2013

@bfroehle done, thanks

@ellisonbg
Copy link
Member

Looks like this has been reviewed and everything looks good. Merging.

ellisonbg added a commit that referenced this pull request May 9, 2013
remove `ipython.py` entry point
@ellisonbg ellisonbg merged commit 21ad63c into ipython:master May 9, 2013
@minrk minrk deleted the remove-ipython.py branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants