-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename %%file
to %%writefile
#3317
Conversation
keeps `%%file` as alias Alternative to ipython#3313, no behavior is changed.
@@ -2055,11 +2055,13 @@ def init_magics(self): | |||
|
|||
# Register Magic Aliases | |||
mman = self.magics_manager | |||
# surely, this can't be were magics aliases should be defined? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than a snarky comment that stays in code, either remove this or put the code somewhere better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a FIXME comment is the right thing to do here as a reminder (will turn down the snark, sorry).
The real fix would be to add a layer to Magics for defining aliases, which is a bit more involved than belongs in this PR, I think.
Looks good to me, other than the above. |
Thanks! Merging now... |
Rename `%%file` to `%%writefile`, leaving `%%file` as an alias for backwards compatibility.
Rename `%%file` to `%%writefile`, leaving `%%file` as an alias for backwards compatibility.
keeps
%%file
as aliasAlternative to #3313, no behavior is changed.