rename %%file to %%writefile
#3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeps `%%file` as alias Alternative to ipython#3313, no behavior is changed.
| @@ -2055,11 +2055,13 @@ def init_magics(self): | |||
|
|
|||
| # Register Magic Aliases | |||
| mman = self.magics_manager | |||
| # surely, this can't be were magics aliases should be defined? | |||
There was a problem hiding this comment.
Rather than a snarky comment that stays in code, either remove this or put the code somewhere better :)
There was a problem hiding this comment.
I think a FIXME comment is the right thing to do here as a reminder (will turn down the snark, sorry).
The real fix would be to add a layer to Magics for defining aliases, which is a bit more involved than belongs in this PR, I think.
|
Looks good to me, other than the above. |
|
Thanks! Merging now... |
fperez
added a commit
that referenced
this pull request
May 15, 2013
Rename `%%file` to `%%writefile`, leaving `%%file` as an alias for backwards compatibility.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Rename `%%file` to `%%writefile`, leaving `%%file` as an alias for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keeps
%%fileas aliasAlternative to #3313, no behavior is changed.