New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPEP 13: user-expressions and user-variables #3319
Conversation
each key will be a rich display_data message rather than plaintext reprs.
I would be carefull in merging this one as it might break on some other project. For example it breaks the ability of the qtconsole to display the list of magics in its menu. |
Thanks for the pointer - I've updated that code to use JSON, which should be cleaner now that user_expressions supports full display data. |
lsmagic now uses JSON, rather than ast eval
avoids ordering issues
Could not just |
The only potential issue I see with that is that |
Also, I think this might affect emacs Ein client, and maybe spyder and canopy. Do we specifically ping those people or just let them discover? |
Spyder here: We don't use |
@ccordoba12 are you using user-expressions/user-variables already in some places, even if it's not for lsmagic ? |
@Carreau: Nope, first time I've heard of them. What's its purpose? |
Execute an expression/retrieve variable value alongside code execution in the kernel: That's what qtconsole use to ask the list of availlable magics in the kernel. |
- pretty / str representation are the regular lsmagic output - JSON repr is just the magics dict with instances replaced with their class names in order to be jsonable. qt magics menu population updated to reflect this.
Would it make sens to have other magics converted like that ? |
it probably would, but I don't think that's relevant to this PR. |
Just asking, just didn't wanted to open a new issue for that. Ok to merge for me. |
thanks, merging away, then. |
IPEP 13: user-expressions and user-variables The user-expressions and user-variables side effects in execute_requests are updated to use the rich-repr display data identical to a display_data message. closes #2654
IPEP 13: user-expressions and user-variables The user-expressions and user-variables side effects in execute_requests are updated to use the rich-repr display data identical to a display_data message. closes ipython#2654
The user-expressions and user-variables side effects in execute_requests are updated to use the rich-repr display data identical to a display_data message.
closes #2654