Allow filename with extension in find_cmd in Windows. #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ipythongh-3316 (hopefully)
|
The test should now be passing with the merge of #3342, but I think this change remains valid - |
|
@jstenar we would like you to take a look at this if you have a chance, or let us know if you don't. Thanks! |
|
tested and works |
minrk
added a commit
that referenced
this pull request
Jul 15, 2013
closes #3316 According to [documentation here](http://docs.activestate.com/activepython/2.4/pywin32/win32api__SearchPath_meth.html), SearchPath takes an optional third parameter for the extension, which is only added if the filename doesn't have an extension.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
closes ipython#3316 According to [documentation here](http://docs.activestate.com/activepython/2.4/pywin32/win32api__SearchPath_meth.html), SearchPath takes an optional third parameter for the extension, which is only added if the filename doesn't have an extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3316
According to documentation here, SearchPath takes an optional third parameter for the extension, which is only added if the filename doesn't have an extension.
Should be tested by someone on Windows.