Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable bracket matching #3368

Merged
merged 1 commit into from
May 28, 2013
Merged

Reenable bracket matching #3368

merged 1 commit into from
May 28, 2013

Conversation

samuela
Copy link
Contributor

@samuela samuela commented May 28, 2013

Resolves #3335. CodeMirror has extracted the bracket matching functionality into an addon which needs to be included.

@Carreau
Copy link
Member

Carreau commented May 28, 2013

Would't this also need the matchBrackets option to be set to true somewhere ? (haven't tried)

@samuela
Copy link
Contributor Author

samuela commented May 28, 2013

No, actually the notebook already was using the matchBrackets option (https://github.com/ipython/ipython/blob/master/IPython/frontend/html/notebook/static/notebook/js/codecell.js#L91). It was just missing the import which I wrote.

@Carreau
Copy link
Member

Carreau commented May 28, 2013

This seem legit. And it is true that bracket matching is not that usefull in markdown...
Thanks, merging.

Carreau added a commit that referenced this pull request May 28, 2013
Reenable bracket matching in CodeMirror. 

Upstream code was moved in a add-on, just load this add-on, configuration was still in the right place.
@Carreau Carreau merged commit dfacc43 into ipython:master May 28, 2013
@samuela
Copy link
Contributor Author

samuela commented May 28, 2013

Great, thanks!

@minrk minrk mentioned this pull request Jul 6, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Reenable bracket matching in CodeMirror. 

Upstream code was moved in a add-on, just load this add-on, configuration was still in the right place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable bracket matching
2 participants