restore "unsaved changes" warning on unload #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autosave is triggered at this event, but it seems to fail sometimes (perhaps when it's too slow?). closes ipython#3475
mention pending autosave, if applicable
|
thanks, I'm going to test this out and report back |
|
This works as expected and is the final step in getting all of the dirty/autosave stuff right. Making progress... |
ellisonbg
added a commit
that referenced
this pull request
Jul 1, 2013
restore "unsaved changes" warning on unload
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
restore "unsaved changes" warning on unload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autosave is triggered at this event, but it seems to fail sometimes (perhaps when it's too slow?).
This restores the "beforeunload" warning message, informing the user that unsaved changes may be lost.
It still triggers an autosave (assuming autosave is enabled), in which case the message is "Autosave in progress".
closes #3475