Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal UI #3605

Merged
merged 57 commits into from
Jan 11, 2014
Merged

Modal UI #3605

merged 57 commits into from
Jan 11, 2014

Commits on Jan 7, 2014

  1. Starting work on select/focus logic.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    7d0f415 View commit details
    Browse the repository at this point in the history

  2. Adding new logic to cells.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    a11c3df View commit details
    Browse the repository at this point in the history

  3. More work on the dual mode UX.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    2dd3d63 View commit details
    Browse the repository at this point in the history

  4. Semi working version of basic dual mode UX. 

    As of this point there are lots of things that don't work, but
most of the basic dual mode interactions do work fine.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    b2c174f View commit details
    Browse the repository at this point in the history

  5. Don't bind notebook keyboard events to $(document). 

    Keyboard events were previously bound to $(document), which
caused problems with our command mode not allowing other
focused elements (dialogs, etc.) to manage their own keyboard
events. We now bind to the notebook element.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    0e882fd View commit details
    Browse the repository at this point in the history

  6. Binding to notebook div not document.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    fef08d9 View commit details
    Browse the repository at this point in the history

  7. Removing manual focusing of notebook div.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    b0aa243 View commit details
    Browse the repository at this point in the history

  8. Adding keyboard manager logic. 

    This is currently very broken.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    9ba9496 View commit details
    Browse the repository at this point in the history

  9. Lots of updates and changes. 

    * Cleaning up the code mirror event handlers.
* Adding logic to prevent calling Notebook.command_mode on cell
  focusout.
* Fixing bugs.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    acac37b View commit details
    Browse the repository at this point in the history

  10. Code comments and minor fixes.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    acf3710 View commit details
    Browse the repository at this point in the history

  11. Removing KBN null mode and replacing with enable/disable.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    0135ad2 View commit details
    Browse the repository at this point in the history

  12. Adding missing enable/disable methods.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    7fc210d View commit details
    Browse the repository at this point in the history

  13. Moving a cell focuses it after the move. 

    This way if you move a cell a long way, the noteobook div will
scroll with you.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    1283ebb View commit details
    Browse the repository at this point in the history

  14. Split cell keyboard shortcut wired up. Merge markdown adds 2nd \n.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    b51276b View commit details
    Browse the repository at this point in the history

  15. Add + for merge cell below and carefully manage split cell state.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    71eb69b View commit details
    Browse the repository at this point in the history

  16. Carefully manage rendered state in merge cell.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    ef87614 View commit details
    Browse the repository at this point in the history

  17. Fixing select when inserting cell using menu.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    e25c9e4 View commit details
    Browse the repository at this point in the history

  18. Fixing bug in KeyboardManager.enable/disable.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    619528c View commit details
    Browse the repository at this point in the history

  19. Changing a heading cell level should enter edit mode and set dirty

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    d5e4ce5 View commit details
    Browse the repository at this point in the history

  20. Fixing delete/undelete logic.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    0f4213e View commit details
    Browse the repository at this point in the history

  21. Using a more specific approach for managing CM focus. 

    I used to try and enter command mode when a cell looses focus. The
problem with that is that focusing an output area would remain in
edit mode.

Now, I bind this logic to the code mirror blur event, so that
focusing the output area enters command mode.
    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    aeffe3b View commit details
    Browse the repository at this point in the history

  22. Delete cell only if you press "d" twice in 1 second.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    6481cb5 View commit details
    Browse the repository at this point in the history

  23. HTML and JavaScript output KBM event handling.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    89eac9e View commit details
    Browse the repository at this point in the history

  24. Like, OMG, keyboardmanager.js is a beast.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    d6a3ec7 View commit details
    Browse the repository at this point in the history

  25. Fixing bugs and adding automatic KB shortcut help.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    c4fda88 View commit details
    Browse the repository at this point in the history

  26. Adding j/k for select next/prev. Faster than up/down.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    9d44616 View commit details
    Browse the repository at this point in the history

  27. Updating help string for ctrl-enter and alt-enter.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    bfc1794 View commit details
    Browse the repository at this point in the history

  28. Pressing d twice now deletes cell on first try.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    c2b3a2b View commit details
    Browse the repository at this point in the history

  29. Fix raw_input.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    e228b93 View commit details
    Browse the repository at this point in the history

  30. shift-enter should doesn't create a new cell at the bottom.

    @ellisonbg
    ellisonbg committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    20c436e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2014

  1. Fixing css class on cell related to selected, rendered, mode.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    5233b21 View commit details
    Browse the repository at this point in the history

  2. Ongoing work on cell splitting.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    bdb4c53 View commit details
    Browse the repository at this point in the history

  3. TextCell.unrender should not focus CM/select.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    cc09699 View commit details
    Browse the repository at this point in the history

  4. Cleanup of cell splitting.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    ad1a6ed View commit details
    Browse the repository at this point in the history

  5. Cell splitting merging works with RawCell now.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    f1ffb2b View commit details
    Browse the repository at this point in the history

  6. Special handling for CM's vim keyboard mapping.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    0d3e611 View commit details
    Browse the repository at this point in the history

  7. Adding back doc in Keyboard Shortcut.

    @ellisonbg
    ellisonbg committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    0202e66 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2014

  1. Don't always call focus_cell in Cell.command_mode. 

    The focus_cell should only be called when a user enters
command mode by pressing ESC. Calling focus_cell was causing
jumps when command mode was entered through a mouse click.
    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    54b48d9 View commit details
    Browse the repository at this point in the history

  2. select next cell in insert cell below in menubar to match kb.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    627a797 View commit details
    Browse the repository at this point in the history

  3. Focus cells after they are inserted.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    538a39b View commit details
    Browse the repository at this point in the history

  4. Fixing a few keyboard codes and shortcuts.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    33dd5d6 View commit details
    Browse the repository at this point in the history

  5. Adding missig altKey test to CodeCell.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    ab3a1dd View commit details
    Browse the repository at this point in the history

  6. Removing old method on RawCell - just use the base class.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    9448c01 View commit details
    Browse the repository at this point in the history

  7. Fixing JS tests.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    dd345f4 View commit details
    Browse the repository at this point in the history

  8. Fixing more JS tests.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    ff51227 View commit details
    Browse the repository at this point in the history

  9. Renaming execute methods.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    b696039 View commit details
    Browse the repository at this point in the history

  10. Reordering conditional.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    6996d42 View commit details
    Browse the repository at this point in the history

  11. Fixing delete_count logic.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    3088dda View commit details
    Browse the repository at this point in the history

  12. Cleaning up console log messages.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    a8751bb View commit details
    Browse the repository at this point in the history

  13. canonicalize -> normalize in keyboard manager.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    dca69cb View commit details
    Browse the repository at this point in the history

  14. Semicolon cleanup.

    @ellisonbg
    ellisonbg committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    5b066a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2014

  1. Adding sorting and better layout to the KB shortcuts.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    2259a24 View commit details
    Browse the repository at this point in the history

  2. Fixing design of quickhelp.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    3be8af8 View commit details
    Browse the repository at this point in the history

  3. Adding basic examples notebook about modal editing.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    6573c62 View commit details
    Browse the repository at this point in the history

  4. Fixing links and text of User Experience notebook.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    ab7fc46 View commit details
    Browse the repository at this point in the history

  5. Minor changes to KB handling.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    66589e1 View commit details
    Browse the repository at this point in the history

  6. Work on shortcuts and examples notebook.

    @ellisonbg
    ellisonbg committed Jan 10, 2014
    Configuration menu
    Copy the full SHA
    a6562f1 View commit details
    Browse the repository at this point in the history