expand terminal color support #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for 256 colors does not yet add support for themed 16-color mapping ([01;38;5;[0-15]) closes ipython#3617
|
fixed! even worked right away for previously saved notebooks. plain-old simple colors also still work. Thanks Min! |
|
should i merge, or were you planning to tackle the themed 16-color mapping in this PR? |
|
16-color mapping should work now, I'd say this is ready to merge. |
|
sweet, great job Min, the example notebook looks nifty. Merging |
ivanov
added a commit
that referenced
this pull request
Jul 13, 2013
expand terminal color support (16 and 256 ANSI colors)
7 tasks
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
expand terminal color support (16 and 256 ANSI colors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for VT100 256 colors, and 24 bit RGB
The only terminal color feature that I am aware of that we still don't support is the ANSI bright / non-bright distinction.
It should also improve the handling of unrecognized color escapes (stripping, rather than leaving untouched).
Definitely needs testing, as the 256-color support is a bit complicated (ping @ivanov).
There is one related benefit that I was able to get this into a single replace call with regular expressions,
rather than a sequence of replacements, so it might be faster than before.
closes #3617