-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup nbconvert templates #3764
Conversation
At the beginning the newlines /whitespace where to keep a perfect matching between nbconvert 1 and 2, so I have no opposition in cleaning them, and thanks a lot for that. So I don't have any objection for HTML ans Latex template, Travis build errored, I just relauched. Tagging 1.0 |
For reference, I have not touched the latex templates because I did not know if the current structure is necessary to render ok... |
OK, I added some fixes in latex templates to be congruent with the others... I did not have to do a lot of modifications because there was more organized than the non-latex templates. |
hum... need rebase. But you might want to wait for #3758 to land. |
I will rebase it in a couples of minutes... I am pushing you another PR ;-) |
@Carreau rebase done ;-) |
Looks like it needs another rebase 😦 |
I will do it in a couple of minutes |
Fixing rebasing conflicts, don't review yet... thanks. |
OK, I don know why travis is failing, probably it has to be run again... I am not familiarize with travis but I can run it again or some of you have to do it? |
Good work @damianavila . I like these kinds of aesthetic changes :) |
Thanks! |
Cleanup nbconvert templates
The templates have a lot of whitespaces, some missing ones... and there is no a pythonic structure when you read the code (some indentations missing an so on...)
So, I propose a clean up of the templates... I think this PR make them more readable and easy to understand for people who want to learn to write their own templates.
Maybe I am missing some details deleting white lines, so I open this PR to discuss and review the changes.
Cheers.
Damián.