Adds an explicit newline for pretty-printing. #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p.break_() explicitly includes a newline while pretty printing, and maintains indentation. A simple test is included to show this working.
When a newline is found in the result of repr() (using the default printer), the newline is replaced with an appropriate call to p.break_()
|
@alexrudy thanks for your contribution. This did not make it into 1.0 alpha or the RC, so I'm marking it as 2.0 material. Ping us if you don't get a review or this starts to go stale after 1.0.0 is release |
|
I don't know enough about pretty to review effectively, but this does seem to work as intended. Does @rkern have an opinion on the functionality? |
|
@ivanov any objections? I'm fine with merging this. |
minrk
added a commit
that referenced
this pull request
Sep 18, 2013
Adds an explicit newline for pretty-printing. Included: - ``p.break_()`` inserts a hard newline in the output, maintaining the correct indentation during pretty printing. - When the pretty printer falls back to the object's ``__repr__`` method, newlines are converted from ``\n`` to ``p.break_()`` to maintain indentation
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Adds an explicit newline for pretty-printing. Included: - ``p.break_()`` inserts a hard newline in the output, maintaining the correct indentation during pretty printing. - When the pretty printer falls back to the object's ``__repr__`` method, newlines are converted from ``\n`` to ``p.break_()`` to maintain indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ not for 1.0 ]
This is a response to issue #2136 to handle hard newlines in pretty printing.
Included:
p.break_()inserts a hard newline in the output, maintaining the correct indentation during pretty printing.__repr__method, newlines are converted from\ntop.break_()to maintain indentationNot Included:
p.text()are not converted to calls top.break_There are three basic tests that I've added to test this functionality.